Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customizing comment leader in editor #2157

Closed
wants to merge 2 commits into from

Conversation

Xiretza
Copy link

@Xiretza Xiretza commented Aug 24, 2023

This allows setting ui.editor-comment-prefix to change the hard-coded JJ: prefix. Empty prefixes are not allowed, and for prefixes without a trailing space, one is added when printing comment lines.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@google-cla
Copy link

google-cla bot commented Aug 24, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Xiretza
Copy link
Author

Xiretza commented Aug 24, 2023

God damnit, should've checked first. What a waste of time.

@Xiretza Xiretza closed this Aug 24, 2023
@ilyagr
Copy link
Collaborator

ilyagr commented Aug 24, 2023

Sorry to see you go. :(

I think Google's CLA doesn't allow Google to relicense your contribution, but I am not a lawyer and didn't research this thoroughly. It's totally fine if you aren't feeling like researching it yourself (or if you have some other concern).

@Xiretza
Copy link
Author

Xiretza commented Aug 25, 2023

Yeah, I suppose it doesn't make that much of a difference with an Apache project, the real gall is corporate GPL projects that require handing over contributions without any conditions.

Unfortunately signing the CLA requires a google accout, so it's a no-go regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants